Skip to content

[csharp][generichost] Fix format string parameter (#22282)#22283

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
macmanad:bugfix/22282-csharp-generichost-format-string
Nov 8, 2025
Merged

[csharp][generichost] Fix format string parameter (#22282)#22283
wing328 merged 2 commits intoOpenAPITools:masterfrom
macmanad:bugfix/22282-csharp-generichost-format-string

Conversation

@macmanad
Copy link
Copy Markdown
Contributor

@macmanad macmanad commented Nov 4, 2025 •
edited
Loading

Fixes #22282 Fix format string parameter referencing index not present in params
@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha

PR checklist

  • [ X] Read the contribution guidelines.
  • [ X] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [X ] Run the following to build the project and update samples
  • [ X] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [X ] If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • [ X] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 5, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@macmanad
Copy link
Copy Markdown
Contributor Author

macmanad commented Nov 5, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

That's fine, it's just a one character change to a format string, not exactly career defining

@macmanad
Copy link
Copy Markdown
Contributor Author

macmanad commented Nov 7, 2025

Added email as secondary

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 7, 2025

cc @devhl-labs

@devhl-labs
Copy link
Copy Markdown
Contributor

devhl-labs commented Nov 7, 2025

I am very confused how it became wrong, no one else mentioned it, and i don't see an issue. Looks good though.

@wing328 wing328 merged commit a144678 into OpenAPITools:master Nov 8, 2025
61 checks passed
@wing328 wing328 added this to the 7.18.0 milestone Nov 8, 2025
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
@macmanad
[csharp][generichost] Fix format string parameter (OpenAPITools#22282) (
11f568c 
OpenAPITools#22283)

* [csharp][generichost] Fix format string parameter (OpenAPITools#22282)

* Update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: C-Sharp Issue: Bug

Projects

None yet

Milestone

7.18.0

Development

Successfully merging this pull request may close these issues.

[BUG] [CSHARP] [generichost]Incorrect format index in AfterOperationDefaultImplementation.mustache

3 participants

@macmanad @wing328 @devhl-labs